GSPLIT REVIEW PATCH

GSPLIT REVIEW PATCH

What do you mean as 'dwarf5 without split-dwarf as an option' here? Do you mean to do split-dwarf by default? It is orthogonal to what this patch does. That said, if we do I'd rather have it as dwarf5 without split-dwarf as an option rather than a -gsingle-file-split-dwarf option. I'm not sure why we would want the ability.

o files rather than introducing the new flag. Yeah, we do not want to split it and I see no other way to say clang to keep them in a. dwo files.ДЄs far as the standard text here, IMO it was just there in case people didn't have an objcopy around or don't want to split it. We don't use objcopy on linux or fuschia to generate.

We do generate them generically with no objcopy hack.Д®ric, could you elaborate for me your position, please debug_*.dwo sections this seems like a build-time win. dwo file directly these days? If not, I can imagine wanting to avoid the overhead of the objcopy hack as long as the linker is smart enough not to bother with the. I am thinking about rewriting the comment and landing it independently.Дo we generate the. It waits for this one, since its test case mentions/uses -gsingle-file-split-dwarf option. The patch for LLDB is ready to be landed: D52403. I guess everything should be fine, but asking just in case. LLD does not ignore '.dwo' sections by name and I do not expect other linkers do (and that is fine, we do not want to ignore sections by name generally), so having this flag is an important and clean thing for things to work.ДЄnd another small question - just wondering if the debuggers (GDB and LLDB) are okay with it / or smth needs to be adjusted or fixed on their side. So if linker supports SHF_EXCLUDE flag properly, it will ignore it properly. LLVM emits them with the SHF_EXCLUDE flag since the rе…ѓ42800 ' - Set SHF_EXCLUDE flag for. This is an interesting observation which I've had on my mind for quite some time as well a couple of things which I have not double-checked yet - just in case - do both gold and lld completely ignore dwo-related sections ? (did you check that ?),

Gsplit review